Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the release process for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is an automated release PR generated by the Changesets action. It updates the version of @googleworkspace/cli to 0.18.0 across package.json, Cargo.toml, and Cargo.lock. The CHANGELOG.md has been updated with the release notes from the consumed changeset files, and flake.lock has been updated accordingly. The changes are consistent with a standard release process and appear to be correct. There are no issues to report.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #547 +/- ##
=======================================
Coverage 69.06% 69.06%
=======================================
Files 42 42
Lines 19261 19261
=======================================
Hits 13302 13302
Misses 5959 5959 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
99a7dde to
3d1515e
Compare
|
/gemini review |
3d1515e to
a5d6c73
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the @googleworkspace/cli project to version 0.18.0, introducing several new features and bug fixes. Key enhancements include automatically populating the 'From' header with display names from send-as settings across all Gmail mail helpers, a significant migration of Gmail mail helpers to the mail-builder crate for RFC-compliant MIME construction, and the addition of a robust --attach flag with upload endpoint support and a new +read helper. Bug fixes address a redundant --attachment argument in +send, correct the behavior of 'reply-all' when responding to one's own message, and consolidate terminal sanitization and output helpers to fix ANSI escape code issues and strip dangerous Unicode characters from outputs. The project's version in Cargo.toml, package.json, and Cargo.lock has been incremented, and the flake.lock file has been updated to reflect changes in the Nix package set.
There was a problem hiding this comment.
Code Review
This pull request primarily focuses on releasing version 0.18.0 of the @googleworkspace/cli package. The changes include updating version numbers in Cargo.toml, Cargo.lock, package.json, and CHANGELOG.md, as well as removing the temporary changeset files. The flake.lock file was also updated to reflect new nixpkgs hashes. Based on the provided diffs, no high or critical issues were identified.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@googleworkspace/cli@0.18.0
Minor Changes
908cf73: feat(gmail): auto-populate From header with display name from send-as settings
Fetch the user's send-as identities to set the From header with a display name in all mail helpers (+send, +reply, +reply-all, +forward), matching Gmail web client behavior. Also enriches bare
--fromemails with their configured display name.6e4daaf: Gmail helpers rollup: mail-builder migration, --attach flag (upload endpoint), +read helper
+send,+reply,+reply-all, and+forwardto themail-buildercrate for RFC-compliant MIME construction--fromflag to+sendfor send-as alias support-a/--attachflag to all mail helpers (+send,+reply,+reply-all,+forward) withmime_guess2auto-detection, 25MB size validation, and upload endpoint support (35MB API limit vs 5MB metadata-only)+readhelper to extract message body and headers (text, HTML, or JSON output)OriginalMessage.thread_idoptional (Option<String>) for draft compatibilitymail-builderUploadSourceenum in executor for type-safe upload strategiesPatch Changes
1e90380: fix(gmail): remove dead
--attachmentarg from+sendThe
+sendsubcommand defined a duplicate"attachment"arg alongside the"attach"arg already provided bycommon_mail_args. Sinceparse_attachmentsreads
"attach", the--attachmentflag was silently ignored. Removed thedead duplicate.
908cf73: fix(gmail): handle reply-all to own message correctly
Reply-all to a message you sent no longer errors with "No To recipient remains." The original To recipients are now used as reply targets, matching Gmail web client behavior.
2e909ae: Consolidate terminal sanitization, coloring, and output helpers into a new
output.rsmodule. Fixes raw ANSI escape codes inwatch.rsthat bypassedNO_COLORand TTY detection, upgradessanitize_for_terminalto also strip dangerous Unicode characters (bidi overrides, zero-width spaces, directional isolates), and sanitizes previously raw API error body and user query outputs.